LibWeb: Make aria-relevant and ariaRelevant reflect #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the aria-relevant content attribute the ariaRelevant IDL/DOM attribute get reflected — which makes the Ladybird behavior interoperable with the implemented behavior in other existing engines. Otherwise, without this change, Ladybird fails the relevant test case in https://wpt.fyi/results/html/dom/aria-attribute-reflection.html — which other existing engines all pass.
This is a straightforward port to our test harness of the WPT test at https://wpt.fyi/results/html/dom/aria-attribute-reflection.html
sideshowbarker
force-pushed
the
make-aria-relevant-get-reflected-as-ariaRelevant
branch
from
bedd759
to
bf9ef53
Compare
sideshowbarker
changed the title
sideshowbarker
deleted the
make-aria-relevant-get-reflected-as-ariaRelevant
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the
aria-relevantcontent attribute and theariaRelevantIDL/DOM attribute reflect — which makes the Ladybird behavior interoperable with the implemented behavior in other existing engines.Otherwise, without this change, Ladybird fails the relevant test case in https://wpt.fyi/results/html/dom/aria-attribute-reflection.html — which other existing engines all pass.
Note that at https://w3c.github.io/aria/#ARIAMixin the
ARIAMixinIDL definition in the current ARIA spec actually lacks theariaRelevantattribute — but I’ve raised w3c/aria#2326 to get that fixed.And note that this change doesn’t actually add support for the
aria-relevant— because we already have support for it; the only thing that was missing was that it wasn’t in ourARIAMixinIDL.Finally: This change also adds a related new in-tree test for ARIA attribute reflection (for all attributes in the current canonical ARIA spec at https://w3c.github.io/aria/). It’s just a port of https://wpt.fyi/results/html/dom/aria-attribute-reflection.html over to our in-tree test harness. Some of the tests currently fail — but that’s expected because we haven’t yet added support for them. But I can add them in a follow-up PR — and after that, all those tests will be green.