LibWebView: Display layouting information in devtools #2443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Specifically, you can now see whether an element is visible, scrollable or creates a stacking context in the devtools.
Psychpsyo
force-pushed
the
devtool-layout-hints
branch
from
ff2b492 to
76c2da4
Compare
konradekk
reviewed
Nov 27, 2024
| extra.append("invisible"_string); | ||
| } | ||
| if (node.get_bool("stackingContext"sv).value_or(false)) { | ||
| extra.append("isolated"_string); |
There was a problem hiding this comment.
the image advertises it as stacking context; yet i still like this name better! 👍
There was a problem hiding this comment.
I switched it after the initial PR and asking on the Discord.
Pros: It is an adjective, also shorter and less awkward
Cons: Many things beyond isolation: isolate; cause an element to create a stacking context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some extra info to the side of nodes in the devtools to indicate whether they are scrollable, invisible or create a stacking context.
It indents a large chunk of the code in InspectorClient.cpp so that these can show up on non-element nodes as well, sine those used to early-exit.
Examples:
Note: "stacking context" has been replaced with "isolated" since.