Merge pull request #1 from Lakshan-Madushanka/feature/browse-movies

Fix Home page filers
Lakshan-Madushanka · Jan 26, 2024 · bef3bf7 · bef3bf7
2 parents 1643ff0 + 9811d97
commit bef3bf7
Showing 1 changed file with 6 additions and 10 deletions.
diff --git a/app/Http/Integrations/YTS/Requests/GetMoviesRequest.php b/app/Http/Integrations/YTS/Requests/GetMoviesRequest.php
@@ -24,8 +24,7 @@ public function resolveEndpoint(): string
 
     /**
      * @param  MovieResponse  $response
-     * @return Collection<string, Collection<int, MovieData>|Collection<int, MovieMetaData>>>
-     *
+     * @return Collection<string, MovieMetaData|array{}|Collection<int, MovieData>>
      * @throws JsonException
      */
     public function createDtoFromResponse(Response $response): Collection
@@ -34,13 +33,12 @@ public function createDtoFromResponse(Response $response): Collection
 
         $movies = $data['movies'] ?? [];
 
-        /** @var Collection<int, MovieData> $moviesDTO* */
-        $moviesDTO = collect();
-        /** @var Collection<int, MovieMetaData> $metaDTO* */
-        $metaDTO = collect();
+        /** @var Collection<int, MovieData> $moviesData **/
+        $moviesData = collect();
+        $metaData = [];
 
         foreach ($movies as $movie) {
-            $moviesDTO->add(
+            $moviesData->add(
                 new MovieData(
                     id: $movie['id'],
                     name: $movie['title_english'],
@@ -59,10 +57,8 @@ public function createDtoFromResponse(Response $response): Collection
                 limit: $data['limit'],
                 page: $data['page_number']
             );
-
-            $metaDTO->add($metaData);
         }
 
-        return collect(['movies' => $moviesDTO, 'meta' => $metaDTO]);
+        return collect(['movies' => $moviesData, 'meta' => $metaData]);
     }
 }