Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMK, Lua] Corrected missions cutscenes #4824

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

Flibe-XI
Copy link
Contributor

@Flibe-XI Flibe-XI commented Dec 6, 2023

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • The mission "An Errand! A Professor's Price!" should end when talking to the inconspicuous door in upper jeuno, not when handing in the starfruit. The cutscene in jeuno is long, and ends with the prompt for digging up the worm-eaten chest of mission 7, but that is the cs that switches over the mission status as according to the capture.
  • Added flavor reminder text to Shantotto to travel to Jeuno after handing in starfruit

Also, there are conflicting reports as to how many cardians spawn based on how many orbs the player has. According to bg-wiki, it goes 1-2: 15, 3: 10, 4: 5. This information is congruent with the number of 'Custom Cardian ids currently in the database, so it is possible it used to be 20 cardians, but now it is 15 maximum. Just removing a comment regarding this.

Steps to test these changes

!addmission 10 4
You should be on mission "5 - Curses!" in the mission log. Talk to shantotto to start the mission, you should then be on mission "6 - An Errand".
!addkeyitem ripe_starfruit
Talk to her again to complete it. Here you should still be on "6 - An Errand".
Talk to Shantotto again to see reminder text to travel to Jeuno.
Travel to upper jeuno and click on the inconspicuous door and get digging instructions. Mission will it switch to "7 - Shock".

@zach2good zach2good merged commit c95840a into LandSandBoat:feature/amk_missions Dec 9, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants