-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Introduce luautils::callGlobal helper #6780
Conversation
6256f6e
to
0ecb9e0
Compare
635a0d0
to
8793c87
Compare
68ebea6
to
a230320
Compare
Ready for review, works with hot-reloading. Will do some performance testing this week to see if we gain anything from the caching layer |
4e0cce6
to
0dcf634
Compare
0dcf634
to
04f7085
Compare
4d1e736
to
1b8a4c3
Compare
1b8a4c3
to
29e9ad8
Compare
Trying to pin down why this is crashing during CS event updates inside LuaJIT |
This ended up shaking out a logical inconsistency that I can't understand why it wasn't crashing before. When you extract something out of sol, it's lazy-evaluated. If you ask for I've added those checks in now. It was around event string updates, so I've run it through the chocobo racing intro, which is the premiere spot for big event updates with arguments and strings. I've logged in, I've done gobbie box, I've punched some lizards in the face, I've called out trusts and Sneak Attacked off of them, I've used items - everything seems stable now. Ready to go 👍 |
I affirm:
What does this pull request do?
Allow calling of functions in Lua from C++ without needing to manually prepare so many things for Lua, or to manually/dangerously access the lua state:
etc.