[lua, cpp] fixes mobskills base damage and ftp naming #6944
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Fixes the base damage used for mobs. For whatever reason mobs based damage was using
weaponDamage + fstr + dLvl? * ftp
https://w.atwiki.jp/studiogobli/pages/13.html
https://www.bg-wiki.com/ffxi/Base_Damage
https://www.bg-wiki.com/ffxi/Physical_Damage
Renames dmgmod to ftp. Based on retail research mob damage is extremely consistent and has been since the release of the game. Any mobskill thats damage cannot vary has the same ftp values at 3,000 TP vs 1,000 TP. After testing 10 different mobskills that have static damages with no damage varies - the damage is always the same from the TP values. This lines up with what you see in game all over the place. Here is just one example.
Gets rid of the duplicate pdif calcs inside the mobskills.lua and uses the global function. There is an edge case that cannonball uses the DEF stat and not he ATT stat so I added a param to the
xi.combat.physical.calculateMeleePDIF
. It looks messy but I didn't know another way to do this. We will need this eventually for bluemage.lua when we convert that over to use the new global.Fixes an issue where Seismostomp was throwing errors Dynamis - Seismostomp throwing errors and zero damage. #6953 (comment)
Steps to test these changes
Go to any mob and !tp 3000 on it for it to use any physical mobskill. Since the base damage is now slightly lower you should see slightly lower damage than before based on if the mob is higher level than you or not.