Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lua, cpp] fixes mobskills base damage and ftp naming #6944

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

Frankie-hz
Copy link
Contributor

@Frankie-hz Frankie-hz commented Feb 4, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Fixes the base damage used for mobs. For whatever reason mobs based damage was using weaponDamage + fstr + dLvl? * ftp
    https://w.atwiki.jp/studiogobli/pages/13.html
    https://www.bg-wiki.com/ffxi/Base_Damage
    https://www.bg-wiki.com/ffxi/Physical_Damage

  • Renames dmgmod to ftp. Based on retail research mob damage is extremely consistent and has been since the release of the game. Any mobskill thats damage cannot vary has the same ftp values at 3,000 TP vs 1,000 TP. After testing 10 different mobskills that have static damages with no damage varies - the damage is always the same from the TP values. This lines up with what you see in game all over the place. Here is just one example.

image

  • Gets rid of the duplicate pdif calcs inside the mobskills.lua and uses the global function. There is an edge case that cannonball uses the DEF stat and not he ATT stat so I added a param to the xi.combat.physical.calculateMeleePDIF. It looks messy but I didn't know another way to do this. We will need this eventually for bluemage.lua when we convert that over to use the new global.

  • Fixes an issue where Seismostomp was throwing errors Dynamis - Seismostomp throwing errors and zero damage. #6953 (comment)

Steps to test these changes

Go to any mob and !tp 3000 on it for it to use any physical mobskill. Since the base damage is now slightly lower you should see slightly lower damage than before based on if the mob is higher level than you or not.

Copy link

github-actions bot commented Feb 4, 2025

✨ Thanks for the PR! ✨

This is a friendly automated reminder that the maintainers won't look at your PR until you've properly completed all of the checkboxes in the pre-filled template.

@Frankie-hz Frankie-hz force-pushed the mobskill_damage branch 3 times, most recently from 7e0e502 to 9879361 Compare February 4, 2025 07:00
@Frankie-hz Frankie-hz marked this pull request as ready for review February 5, 2025 01:35
Copy link
Contributor

@Xaver-DaRed Xaver-DaRed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Except for the cannpnball thing.

A work for another time, however, instead of feeding "is this one specific action" we could have fed "what do we use as attack" and improve both the functionality and flexibility.

But, thats a job for future-someone-else-lets-hope-not-me

@Frankie-hz Frankie-hz changed the title [lua] fixes mobskills base damage and ftp naming [lua, cpp] fixes mobskills base damage and ftp naming Feb 6, 2025
Fixes the base damage used for mobs
Converts pdif calcs into the global physical utilities formula
@zach2good zach2good merged commit 8ca645e into LandSandBoat:base Feb 6, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants