[lua&sql] Alterations to Trust: Monberaux logic and spells. Added trade for Elixir and Gil. #6950
Conversation
Add Slow, Elegy, Requim and Helix' to erasable table, as per bgwiki. https://www.bg-wiki.com/ffxi/Erase
|
Please don't use Tab when making new lines, would need to convert them to spaces. |
Understood thank you, I've converted to draft - because even though all is working server side, I need to clean up the errors, going through them currently. |
shigukahz
force-pushed
the
base
branch
2 times, most recently
from
7841646 to
d2d8aca
Compare
sql/mob_skills.sql
Outdated
| INSERT INTO `mob_skills` VALUES (4259,2610,'mix_dragon_shield',1,0.0,7.0,2000,100,3,4,0,0,0,0,0); -- verified, but no effect messaging is probably wrong | ||
| INSERT INTO `mob_skills` VALUES (4260,2611,'mix_dark_potion',0,0.0,7.0,2000,100,3,4,0,0,0,0,0); -- verified, but check if correct messaging. | ||
| INSERT INTO `mob_skills` VALUES (4261,2612,'mix_samsons_strength',1,0.0,7.0,2000,100,3,4,0,0,0,0,0); -- verified, but check no effect messaging | ||
| INSERT INTO `mob_skills` VALUES (4231, 2613, 'mix_final_elixir', 0, 0.0, 14.0, 2000, 1000, 3, 4, 0, 0, 0, 0, 0); -- Trust: Monberaux Final Elixir |
There was a problem hiding this comment.
No spaces
INSERT INTO `mob_skills` VALUES (4231, 2613, 'mix_final_elixir', 0, 0.0, 14.0, 2000, 1000, 3, 4, 0, 0, 0, 0, 0); -- Trust: Monberaux Final Elixir
Should look like this
INSERT INTO `mob_skills` VALUES (4231,2613,'mix_final_elixir',0,0.0,14.0,2000,1000,3,4,0,0,0,0,0); -- Trust: Monberaux Final Elixir
That is how the other mob_skills is setup
Changes made to Trust: Monberaux and Monberaux in Upper Jeuno for the follow; Added Elixir/Hi-Elixir and Gil trading to his NPC in Upper Jeuno to allow the function of his AoE status removal and his Final Elixir mechanics. Changed his Trusts mJob and sJob to PLD/RUN to reflect his status as shown on BGWiki. Edited his spells so that if they don't remove the effect they show a "No effect on player" message, mainly only matters for AoE potions. Changed SQL for mob_skills to correct some animations and make one list of the status removal AoE and the other not. Renamed most of his skills in mobskills to have mix_ in front to hopefully avoid confusion with other potential applications. All spells range changed from 7 to 14 to accommodate his "NO_MOVE" trust behaviour, he would previous stand out of random and continuously loop some spells because he couldn't reach. No his spells are more in like with White Magic range.
|
Here are captures I made last year for this process: Monberaux gil and Elixer trading - Trust Monberaux fighting and Lhe Lhangavo fighting |
If I'm understanding correctly, the IDs for the event are 'No gil donation' = 10237, 'Performing gil donation' = 10238, 'has gil donation' = 10239 || and in same order for elixir, 10241, 10243, 10244? |
|
Do you think you're able to handle adding the events? If not we could punt it for later. We don't really want to add printToPlayer messaging because it's not accurate |
I'm not confident I could accurately add all the startEvents and get the params correct to be honest. Haven't touched on those yet at all. EDIT: I may have figured it out, I will test full later and let you know. |
Swapped out the printToPlayer aspects and adding the start events. Will accept the item, and correctly say thank you for the correct itemID. If trying to trade when his max cvars are reached, will play appropriate csid. Max Elixirs and Minimum Gil entered as variables so they can be changed per server needs.
I have updated the NPC file for Monberaux now, working on my local server with events rather than prints, for both items and the gil. Does the CVar used matter, or are the ones I've chosen okay? |
WinterSolstice8
added
the
squash
Changed how much gil he asks the player for to be 10% of their current gil, with a threshold of 10,000 min and 100,000 max.
zach2good
removed
the
squash
I affirm:
What does this pull request do?
Changes made to Trust: Monberaux and Monberaux in Upper Jeuno for the follow;
Added Elixir/Hi-Elixir and Gil trading to his NPC in Upper Jeuno to allow the function of his AoE status removal and his Final Elixir mechanics.
Changed his Trusts mJob and sJob to PLD/RUN to reflect his status as shown on BGWiki.
Edited his spells so that if they don't remove the effect they show a "No effect on player" message, mainly only matters for AoE potions.
Changed SQL for mob_skills to correct some animations and make one group of the status removal spells AoE and the other not.
Added 2 new spell timers into his logic, he's meant to cast Mix I potions on a 3-4 second intervals, the Mix II on 60 second intervals, and Mix III at 90 seconds. Currently he is doing all spells on 3 second intervals, this should correct and bring him closer to retail timing.
Renamed most of his skills in mobskills to have mix_ in front to hopefully avoid confusion with other potential applications. All spells range changed from 7 to 14 to accommodate his "NO_MOVE" trust behaviour, he would previous stand out of random and continuously loop some spells because he couldn't reach. No his spells are more in like with White Magic range.
Steps to test these changes
To test his NPC to see how it handles the trading of Gil and Elixirs: I have tried many different trade combinations to confirm the correct ones I was aiming for worked for each CVar. Using !checkvar Player "monbAoe" and !checkvar Player "finalElixir" I was able to confirm the trades for each section were working correctly.
To test his Trust: To test his on spawn text logic, I used !setplayervar to try the combinations required to get all the text outputs, ensuring each one was given when needed.
Tested all of his status removal spells by having an effect added onto my character and see how he responds, with both AoE setting on and off.