Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Correct Aquarius Fransisca drop #7009

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

Xaver-DaRed
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

As title sais
https://www.ffxidb.com/zones/153/aquarius

As noted, the rates among TH tiers suggest that the drop is grouped, so TH doesnt apply, which means we can use the median to guess the rate at 90%

If anything, it isnt guaranteed anyway.

Steps to test these changes

None

@Xaver-DaRed Xaver-DaRed changed the title [Fix] Correct Aquarius Franchisca drop [Fix] Correct Aquarius Fransisca drop Feb 10, 2025
@CriticalXI
Copy link
Contributor

CriticalXI commented Feb 10, 2025

I don't believe that the drop is grouped. If an item is rare it won't drop whatsoever, so the reported drop rate from FFXIDB is lowered due to this. If anyone running the guildwork addon had francisca already in their inventory somewhere and they killed aquarius in a group where everyone had it already, then it would report a lower drop rate.

@CriticalXI
Copy link
Contributor

CriticalXI commented Feb 10, 2025

You can see this on Jelly ring, coffer keys, any item where the drop is rare the ffxidb rate is going to be lower than it actually is.

@Xaver-DaRed
Copy link
Contributor Author

Xaver-DaRed commented Feb 10, 2025

This isnt a mere matter of data pollution due to how rare/ex items work.
We are also not speaking about a regular mob one can jusg kill hundreds of.

This is a NM on the route to Fafnir. One could argue it could have been killed by ppl on the way to it, but considering that in era you probably couldnt solo it, the fact its a lotery mob and the fact the only drop this mob has is the fransisca, I find it incredibly difficult to believe its a mere matter of data pollution. We are speaking about over 11.5% of the kills happened when everyone involved had the fransisca, a mob that had 0 reason to be killed for other than for it.

If we doubt such a significant error margin, at that point we would have to doubt every single drop rate we have, making the whole process pointless. This isnt a 1 or 5 %, this is 11.5%.

Since data pollution is a real thing, I opted to round the drop up instead of down. I will remind that whenever we are in doubt, the procedure is to always adjust in player's detriment, because that is less hurtfull to downstream servers than to adjust in players favor.

@zach2good zach2good merged commit ab03ff3 into LandSandBoat:base Feb 21, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants