Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lua][salvage] Zhayolm Remnants workup and salvage global file system #7045

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

KnowOne134
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Adds the mechanics for all of salvage in zone Zhaylom Remnants.
setup global file for all zone for future work to spawn mobs, open doors, lock doors, count killed groups, slots, and socket mechanics.
updates mixins for ramparts and gears for future use
ramparts have 2 modes, passive and timed reinforcements.
adds the function for timed reinforcements that can be used at idle to spawn mobs at will.
updated the doors code on ramparts, future pr for skill changes as only certain skills can be used when open or closed.
future gears code changes is that agro ranges can change 2x or 1/2 depending on weather/day, effects single and triples.

Steps to test these changes

!instance 7300

@KnowOne134 KnowOne134 force-pushed the Salvage-ZH branch 6 times, most recently from b725e12 to 521d160 Compare February 15, 2025 19:00
@zach2good zach2good merged commit 7ab3134 into LandSandBoat:base Feb 18, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants