Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lua&sql] Trust addition; Rahal, Karaha and Areuhat #7063

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

shigukahz
Copy link
Contributor

Added gambit logic and sql data for ; Rahal, Karaha-Baruha, Areuhat

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

This PR adds the trusts Rahal, Karaha-Baruha and Areuhat.

Rahal:
Added mod Dragon Killer rank 1 (8%)
Added his 4 weapon skills.
Added his gambit logic.

Karaha-Baruha:
Added his gambit logic.
Added his missing spells to spell list (protect1-5 and shell1-5).
Added HPP/MPP mods.
Added 4 out of 5 of his weapon skills.

Areuhat:
Added gambit logic.
Updated weapon skills Dragon Breath and Hurricane wing to have the correct skillchain properties.
Added Enhanced Blood Rage and Demon Killer to mods.
Updated jobs from WAR/ to WAR/PLD to match BG Wiki.

Steps to test these changes

To test Karaha-Baruha's barelemental logic, I have forced mobs to use all of the elements to ensure he registers each one, and also added in logic so that he doesn't keep trying to reapply the same barspell.

To test Areuhat's wyrmlike personality, I've had her fight Demon type mobs to ensure that she can intimidate them with Demon Killer rank 1 active.

All trusts were tested in combat and animations seemed correct apart from Karaha-Baruha's Lunar Bay which has been commented out in the SQL until its corrected.

@shigukahz shigukahz force-pushed the trust_work branch 2 times, most recently from 473e05f to 8d4596c Compare February 17, 2025 10:58
Added gambit logic and sql data for ; Rahal, Karaha-Baruha, Areuhat
@shigukahz shigukahz marked this pull request as ready for review February 17, 2025 11:35
@zach2good zach2good merged commit 8adfa5a into LandSandBoat:base Feb 18, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants