Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lua] add module for pre TOAU signet #7065

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

Grahf0085
Copy link
Contributor

@Grahf0085 Grahf0085 commented Feb 17, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

This PR remove the def and evasion bonus signet had added to the player since 2007. Also, player will heal for less and lose TP when healing with signet. There is a link at top of each lua file. If you open link and search for "signet" you will see the changes.

Destined to be wildly popular

Steps to test these changes

Add the following to init.txt

 era/lua/cop_signet.lua
era/lua/cop_signet_healing.lua

Get signet from gate guard
Attack monster that's an even match or higher in region under your nations control. Your def shouldn't change.
!tp 2000
!hp 1
/heal
Should loose tp when healing.

Copy link
Contributor

@zach2good zach2good left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, you just need to shake it until you can get it to pass CI

@Frankie-hz
Copy link
Contributor

Since these were added in the same patch, is there a reason they can’t be in that same module file called cop signet? If we start breaking out every little difference in things into all separate modules it’s going to get extremely bloated

@Grahf0085
Copy link
Contributor Author

Since these were added in the same patch, is there a reason they can’t be in that same module file called cop signet? If we start breaking out every little difference in things into all separate modules it’s going to get extremely bloated

Good call. I tried that and it seemed to work. Moved everything to one file.

@Grahf0085
Copy link
Contributor Author

Seems reasonable, you just need to shake it until you can get it to pass CI

Thanks for supporting somewhat silly things like this.... the really old stuff

@zach2good zach2good merged commit bcbfedf into LandSandBoat:base Feb 20, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants