Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send new timer packet when battlefield time limit is adjusted #7096

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Send new timer packet when battlefield time limit is adjusted #7096

merged 2 commits into from
Feb 20, 2025

Conversation

eqbot
Copy link
Contributor

@eqbot eqbot commented Feb 19, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Resolves issue #911

Steps to test these changes

  1. Enter a BCNM (I used Treasures and Tribulations)
  2. Use setbattlefieldtime GM command to edit the time limit on the battlefield
  3. Countdown clock now shifts with changes to the battlefield time limit

@eqbot eqbot changed the title Issue 911 2 Send new timer packet when battlefield time limit is adjusted Feb 19, 2025
@Xaver-DaRed Xaver-DaRed added the squash Reminder to squash commits before/on merge (you can do this, or maintainers will do this for you) label Feb 19, 2025
Xaver-DaRed
Xaver-DaRed reviewed Feb 19, 2025
View reviewed changes
scripts/commands/setbattlefieldtime.lua Outdated
end

commandObj.onTrigger = function(player, minutes)
local battlefield = player:getBattlefield()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the whitespace padding here, please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly. I accidentally let it ride along from a different file.

@eqbot eqbot marked this pull request as ready for review February 19, 2025 23:39
@WinterSolstice8 WinterSolstice8 removed the squash Reminder to squash commits before/on merge (you can do this, or maintainers will do this for you) label Feb 20, 2025
@zach2good zach2good merged commit ecfb151 into LandSandBoat:base Feb 20, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xaver-DaRed Xaver-DaRed Xaver-DaRed left review comments

@WinterSolstice8 WinterSolstice8 WinterSolstice8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eqbot @Xaver-DaRed @WinterSolstice8 @zach2good