Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to fit 50,000 into a signed int to compare to -1.
I affirm:
What does this pull request do?
Fixes #7092
Default
DAILY_TALLY_LIMIT
is 50k, -1 is the uninitialized state before you unlock it. When comparing to -1, 50k is treated as a negative signed integer so the update query was producing incorrect results.Steps to test these changes
If
char_points.daily_tally
is negative, talk to one of the gobs and it should set it to 50, then either wait till JP midnight or what I did was adddailytally::UpdateDailyTallyPoints();
in the hourly update here. See daily tally correctly increase.