Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix daily tally limit type #7097

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

cocosolos
Copy link
Contributor

Need to fit 50,000 into a signed int to compare to -1.

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Fixes #7092

Default DAILY_TALLY_LIMIT is 50k, -1 is the uninitialized state before you unlock it. When comparing to -1, 50k is treated as a negative signed integer so the update query was producing incorrect results.

Steps to test these changes

If char_points.daily_tally is negative, talk to one of the gobs and it should set it to 50, then either wait till JP midnight or what I did was add dailytally::UpdateDailyTallyPoints(); in the hourly update here. See daily tally correctly increase.

Need to fit 50,000 into a signed int to compare to -1.
@zach2good zach2good merged commit 78eb492 into LandSandBoat:base Feb 20, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

daily_tally is not tabulating correctly
3 participants