Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lua] Save Survival Guide TP menu user choice #7100

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

sruon
Copy link
Contributor

@sruon sruon commented Feb 20, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

When attempting to change the way the Survival Guide teleport menu presents options (either by region or content), the flag is always saved as 1 in char_unlocks, regardless of the selected option in the menu. This PR resolves the issue.

Steps to test these changes

Use a "Survival Guide"

  • "Other Mysteries"
  • "Select by region/content"

Back out of the menu, use the "Survival Guide" again and confirm it's displaying teleports according to your choice.

Blob saved in DB will correctly save the Survival Guide layout as 0/1 instead of always being set to 1
@sruon sruon changed the title Save Survival Guide TP menu user choice [lua] Save Survival Guide TP menu user choice Feb 20, 2025
@zach2good zach2good merged commit bee88e8 into LandSandBoat:base Feb 20, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants