-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lua] [sql] [Quest] Two Horn the Savage Implementation #7102
base: base
Are you sure you want to change the base?
[lua] [sql] [Quest] Two Horn the Savage Implementation #7102
Conversation
9b14bdf
to
67dd71e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me, but I'd want @KnowOne134 and @claywar to cast their wise eyes over it
['Cacaroon'] = | ||
{ | ||
onTrigger = function(player, npc) | ||
if quest:getVar(player, 'Temp') == 1 then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for var reference in the quest system we are going to start ultizing a pattern again. please use vars Prog, Stage, Option, Wait with these we should be able to handle every situation that may arise and even bit pack them is needed.
so this var should be tagged with the 'Option' label as its an optional CS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also does this cs still pay after the trade of 1000 gil? if not it could just be if var prog == 0 :oncePerZone() instead of even needed the option var set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plays after the player pays 1k gil. Swapped over to if quest:getVar(player, 'Prog') >= 1
Will continue to play once per zone from then forward until the quest is complete. Consistent with what was found in captures.
{ | ||
onTrigger = function(player, npc) | ||
local progress = quest:getVar(player, 'Prog') | ||
local liquid = npc:getID() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for the ocal here, its only being called 1x, just move the logic to the check
if npc:getID() == ID.npc.QUEST_LIQUID then
{ | ||
onMobDeath = function(mob, player, optParams) | ||
if quest:getVar(player, 'Prog') == 2 then | ||
quest:setVar(player, 'Prog', 3) -- Zoning will NOT reset progress. Progress is gained and kept as long as the NM has died. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be a ocal var as zoning loses the info and must fight again, adjust the code above as well to reflect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Zoning does not lose the value and does not require you to fight the NM again. This was tested in captures.
@@ -43,7 +44,8 @@ zones[xi.zone.MAMOOK] = | |||
}, | |||
npc = | |||
{ | |||
LOGGING = GetTableOfIDs('Logging_Point'), | |||
LOGGING = GetTableOfIDs('Logging_Point'), | |||
QUEST_LIQUID = GetTableOfIDs('Viscous_Liquid')[6], -- Used in quest Two Horn the Savage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thinking we should just use:
VISCOUS_LIQUID = GetTableOfIDs('Viscous_Liquid')
then reference the 6th id in the quest script, so if code needs others in future edits wont be needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clay suggested I do it this Way. As far as I'm aware, this quest is the only other content that uses Viscous Liquids besides the illusion effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claywar thoughts on change or eave as is, coud also remove comment about what it is if change made.
not liking the naming of it as quest_liquid then saying what its for after, just personal prefences really, but i like consistancy.
-- !spawnmob 17043871 | ||
-- Viscous Liquid !pos -262.437 5.130 -141.241 | ||
----------------------------------- | ||
mixins = { require('scripts/mixins/families/mamool_ja'), require('scripts/mixins/weapon_break') } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mixins =
{
require('scripts/mixins/families/mamool_ja'),
require('scripts/mixins/weapon_break')
}
67dd71e
to
684424f
Compare
Co-Authored-By: 0x05010705 <[email protected]>
684424f
to
3e2cd53
Compare
I affirm:
What does this pull request do?
Adds the quest Two Horn the Savage
Steps to test these changes
Sources
https://youtu.be/o_aWAEJjxvs
Capture logs broke part way through. Logging out breaks the capture suite.
https://drive.google.com/drive/folders/1D0uhQ1VqkoKJtqEmj9Fu-6BrcyH0mtjJ?usp=sharing
NM Kill + Finish Quest (Packets Only)
https://1drv.ms/u/c/87e665e10555c452/Ebv7ERqzu1xErLiYf_Rci7YBVgLBkL6SV7L5wMBVRUYzfA?e=BZEFgB
Quest: Two-Horn the Savage
*Includes partial capture of Rat Race as one of the wikis had erroneous info that was checked.
https://www.youtube.com/watch?v=Yy_7jWLgrOg
https://drive.google.com/drive/u/1/folders/1P7hHf2obpp0n9yc9PczOLmxfncSKniR2
NM HP Capture
https://youtu.be/ydD0venpAKY
https://1drv.ms/u/c/87e665e10555c452/Ef_HDjh22A9AmQM-VvBh55wB1eNhXTdzIt81N6PBKL5Kkw?e=iLLclv
Immunities + BLU + MDB MDT BDT Testing
https://youtu.be/cmEC9NJfZeo
https://1drv.ms/u/c/87e665e10555c452/EU7_ieBAn6tBhj_5sG7efOYB5HIDKZuyomSnAHZb-V883g?e=fpIdhX
Mamool Ja NM testing regen + kiting + axe throw mobskill
https://youtu.be/nv-GKqkq9Qk
https://1drv.ms/u/c/87e665e10555c452/EYNdkvMle59ImZ0oKssglr4BgMn9VgBHtZAQ0UL5o9iI9w?e=5lnkz5
NM - Mamool Ja mobskill list test (From Two Horn the Savage Quest)
https://youtu.be/jLnJ8OUaugc
https://1drv.ms/u/c/87e665e10555c452/EWSExBX57INCmSoz6I5ymm4Bwdp72RUdfOVgoeoFG0mm0A?e=SbN2P4