Quest: Convert The Fighting Fourth to IF #7116
Open
+283
−164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I left the Adelbrecht script behind, since it has a lot of notes in it |
zach2good
force-pushed
the
wotg_bastok_nation_quests_1
branch
from
381fd84 to
25e2a63
Compare
dallano
reviewed
Feb 21, 2025
| -- TODO: Verify the check for rations exists on retail | ||
| if hasLetter or hasRations then | ||
| -- You won't be considered a member of the Fighting Fourth until you take that blue recommendation letter to Bastok... | ||
| return quest:progressEvent(8) |
There was a problem hiding this comment.
It's my understanding that if the event doesn't progress the quest in some way, it should simply call:
Suggested change
| return quest:progressEvent(8) | |
| return quest:event(8) |
| return quest:progressEvent(139, 0, 0) | ||
| else | ||
| -- Greetings, civillian. The Seventh Cohors of the Republican Legion's Fourth Division is currently recruiting new troops. | ||
| return quest:progressEvent(139, 1, 23) |
There was a problem hiding this comment.
Do these 1 and 23 represent anything specific?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
I didn't see that this was already implemented (poorly) until I was 90% done and wondering why I was getting 2x Sprinters Shoes on completion...
Done using these caps: https://discord.com/channels/443544205206355968/446470824791375892/1264648183854923892
and exhaustive exploring of the CSs around the CSs I saw in the caps, etc.