[Lua, SQL] Fix bugs in confrontation, add IDs to valkurm

[Flibe-XI]

I affirm:

• I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
• I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
• I have read and understood the Contributing Guide and the Code of Conduct.
• I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Improves a number of things required for confrontations to work properly

1. Add function annotations
2. Addresses some edge case bugs that cause confrontation to break down when players re-enter the zone without confrontation effect
3. Add time limit functionality to confrontations
4. Prepare player list for appropriate enmity list management on pop (To be added to npcUtil.lua)
5. Update confrontation effect flag to include xi.effectFlag.ON_ZONE
6. Add some mob IDs to valkurm IDs.lua for pirates chart quest
7. Add some text IDs to outer horutoto ruins IDs.lua

Steps to test these changes

Setup some dummy confrontation somewhere, such as qm4 in valkurm dunes (!pos -168 4 -131 103, id = 17199740)
Test out numerous edge cases for wins and losses.
Player can still force win with multiple players because hate list doesn't autopopulate all alliance members. So spawning player can pop mobs, then zone. Mobs will then despawn, and because valid player count > 0, win condition triggers. This can be fixed by adjusting the logic in npcUtil.lua to include the enmity player list logic. To be handled in separate PR.

coauthor: TracentEden [email protected]
github.com/AirSkyBoat/AirSkyBoat 0c8cb7e
github.com/AirSkyBoat/AirSkyBoat 3881abe

[KnowOne134]

can we put these in alpha order

[Flibe-XI]

I can do that - Is that the format going forward? I haven't seen any "IDs.lua" file follow that format yet, but it makes sense to me

[Xaver-DaRed]

If we use a raw id, like with text ids, we follow the id order.
With this ones we are moving away from raw ids, so we have to follow another order. Alphabetical order makes sense

[zach2good]

I've purged all information about this system from my mind since I originally wrote it, so I'm going to have to assume this all does as you say it does 😆

[zach2good]

To get proper GH attribution, you have to add this line to the commit message:

Co-Authored-By: TracentEden <[email protected]>

Otherwise it won't pick it up

[zach2good]

Can you make sure to test other things that use confrontation? Garrison, the AMK Cardian Fight, etc.?

[Flibe-XI]

To get proper GH attribution, you have to add this line to the commit message:

Co-Authored-By: TracentEden <[email protected]>

Otherwise it won't pick it up

Got it thanks. Will fix tonight.