[lua][Quest] Setting Sun to if #7132
Open
+85
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KnowOne134
force-pushed
the
quest-setting_sun
branch
from
b0f59ab to
dfca3a7
Compare
Xaver-DaRed
reviewed
Feb 25, 2025
| { | ||
| check = function(player, status, vars) | ||
| return status == xi.questStatus.QUEST_COMPLETED and | ||
| not player:needToZone() |
There was a problem hiding this comment.
This suggests that you must have zoned for that event to play.
However, this video shows otherwise: https://www.youtube.com/watch?v=ygF_INPGERQ
There was a problem hiding this comment.
your right i added the wrong direction for that cs, corrected
KnowOne134
force-pushed
the
quest-setting_sun
branch
from
dfca3a7 to
3f38bba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Moves the Quest: Setting Sun to IF system
no logic changes made.
Steps to test these changes
quest starts and completes
!addquest 0 BLACKMAIL, !completequest 0 BLACKMAIL
!pos -137.070 10.999 161.855 231 and trigger npc to start quest outlined here:
https://ffxiclopedia.fandom.com/wiki/The_Setting_Sun