Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile #20

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Update Makefile #20

merged 2 commits into from
Feb 28, 2024

Conversation

dwRchyngqxs
Copy link
Contributor

Remove with_coverage as it is no longer needed

Remove `with_coverage` as it is no longer needed
Removed unneeded reference to `make with_coverage`.
@dwRchyngqxs
Copy link
Contributor Author

I'm wondering why there is an explanation to run a local webserver with python.
The coursework directory is shared so they can just open the webpage with their webbrowser.

@Fiwo735 Fiwo735 self-requested a review February 27, 2024 02:13
Copy link
Collaborator

@Fiwo735 Fiwo735 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting that, as otherwise that might've caused some confusion!

@Fiwo735
Copy link
Collaborator

Fiwo735 commented Feb 28, 2024

I'm wondering why there is an explanation to run a local webserver with python. The coursework directory is shared so they can just open the webpage with their webbrowser.

I think that was done so that it's easier to open directly through VSCode by clicking on the link in the terminal or the prompt that asks to open it in the default browser,

@Fiwo735 Fiwo735 merged commit 0d02251 into LangProc:main Feb 28, 2024
1 check failed
@Jpnock
Copy link
Collaborator

Jpnock commented Feb 28, 2024

Remove with_coverage as it is no longer needed

I kept this for backwards compat reasons, since there's no harm in running the command (it just builds your compiler with coverage data as you'd expect) but for people using it they might get a bit confused once it no longer works for them

@Fiwo735
Copy link
Collaborator

Fiwo735 commented Feb 28, 2024

I kept this for backwards compat reasons, since there's no harm in running the command (it just builds your compiler with coverage data as you'd expect) but for people using it they might get a bit confused once it no longer works for them

Makes sense. hopefully they'd pull the newest version and notice that, but in any case I'll look out for any issues on Ed!

@dwRchyngqxs dwRchyngqxs deleted the patch-2 branch May 2, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants