Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing a fix for StyleCI being trigger happy #3828

Merged
merged 2 commits into from
Sep 10, 2021

Conversation

tabacitu
Copy link
Member

@tabacitu tabacitu commented Sep 9, 2021

And changing files it has no deal changing, that were not edited in those PRs. Like in :

No idea what the issue is, but I bet it's a StyleCI glitch. If that's the case, maybe this stupid empty PR will also trigger StyleCI, and have it make those changes on master. Then those PRs won't have any inconsequential changes that we need to look over... 🤞

@tabacitu tabacitu self-assigned this Sep 9, 2021
@tabacitu
Copy link
Member Author

tabacitu commented Sep 9, 2021

Update - yes it did. So if we merge this to master, we won't have those edits in the PRs.

Then again, keeping this kind of style-ci-edits-even-unedited-files-in-PRs-behaviour would make ALL PRs a bit uncomfortable to work with so... let's hope StyleCI fixes this on their end... 🤞

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@tabacitu tabacitu merged commit 4b9ab1f into master Sep 10, 2021
@tabacitu tabacitu deleted the style-ci-trigger-happy-issue-sep-2021 branch September 10, 2021 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants