fix switch when no color is given #5751
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabacitu
added
the
Minor Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
When no color was given to the switch column, and
--bg-switch-checked-coloris not defined in the CSS, the switch column wasn't visible at all:AFTER - What is happening after this PR?
In that niche use case, the switch is visible and defaults to absolute black:
HOW
How did you achieve that, in technical terms?
Set a default to the CSS variable.
Is it a breaking change?
No.
How can we test the before & after?
You can disable our purple stylesheet in our demo - then that CSS variable will not exist. In that case, in our MonsterCrudController, the switch will no longer be visible.