Fixed passing of references and registered variables to the document …

…function
LaravelFreelancerNL · May 16, 2022 · 9f988c4 · 9f988c4
1 parent bc82109
commit 9f988c4
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/src/QueryBuilder.php b/src/QueryBuilder.php
@@ -164,7 +164,6 @@ public function registerVariable(
         if (is_string($variableName)) {
             $variableName = [$variableName => $variableName];
         }
-
         if (is_array($variableName)) {
             $this->variables = array_unique(array_merge($this->variables, $variableName));
         }

diff --git a/src/Traits/NormalizesMiscellaneousFunctions.php b/src/Traits/NormalizesMiscellaneousFunctions.php
@@ -44,7 +44,7 @@ protected function normalizeDocument(QueryBuilder $queryBuilder): void
         }
         $this->parameters['id'] = $queryBuilder->normalizeArgument(
             $this->parameters['id'],
-            ['Id', 'Key', 'Query', 'List', 'Bind']
+            ['RegisteredVariable', 'Reference', 'Id', 'Key', 'Query', 'List', 'Bind']
         );
     }
 

diff --git a/tests/Unit/AQL/MiscellaneousFunctionsTest.php b/tests/Unit/AQL/MiscellaneousFunctionsTest.php
@@ -65,6 +65,16 @@ public function testDocumentFunction()
         $qb = new QueryBuilder();
         $qb->return($qb->document(['users/john', 'users/amy']));
         self::assertEquals('RETURN DOCUMENT(["users/john","users/amy"])', $qb->get()->query);
+
+
+        $qb = new QueryBuilder();
+        $qb->let('variable', 'collection/a')
+            ->return($qb->document("pages", 'variable'));
+
+        self::assertEquals(
+            'LET variable = @' . $qb->getQueryId() . '_1 RETURN DOCUMENT(pages, variable)',
+            $qb->get()->query
+        );
     }
 
     public function testCurrentDatabase()