launcher: restore starter functionality to launch with l2 #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octobocto
reviewed
Jan 28, 2025
octobocto
reviewed
Jan 28, 2025
octobocto
approved these changes
Jan 28, 2025
|
needs a rabse |
added 9 commits
January 28, 2025 11:29
mplatt8
force-pushed
the
restore-starter-launch
branch
from
7533988 to
38e401a
Compare
octobocto
requested changes
Jan 28, 2025
mplatt8
force-pushed
the
restore-starter-launch
branch
from
2231559 to
9637291
Compare
octobocto
reviewed
Jan 28, 2025
Comment on lines
+187
to
+191
| final startError = canStart(binary); | ||
| if (startError != null) { | ||
| log.e('Cannot start ${binary.name}: $startError'); | ||
| throw Exception(startError); | ||
| } |
There was a problem hiding this comment.
this check is overkill imo, because it's also added as a check on the 'launch'-button.
but not a big deal, only remove it if you want
octobocto
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.