Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add env config for node reachability check #123

Merged
merged 4 commits into from
May 15, 2024
Merged

Add env config for node reachability check #123

merged 4 commits into from
May 15, 2024

Conversation

pschork
Copy link
Collaborator

@pschork pschork commented May 11, 2024

@pschork pschork requested a review from shrimalmadhur May 11, 2024 01:32
@pschork pschork mentioned this pull request May 11, 2024
Merged
5 tasks
jianoaix
jianoaix approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@jianoaix jianoaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shrimalmadhur can we add the reachability metric to the dashboard?

mainnet/.env.example Outdated Show resolved Hide resolved
@pschork
Copy link
Collaborator Author

pschork commented May 14, 2024 •
edited
Loading

Update DA dashboard
image

Dispersal port blocked
image

Operator did not update .env with NODE_DATAAPI_URL or disabled reachability checks via NODE_REACHABILITY_POLL_INTERVAL=0
image

@pschork
Add monitoring dashboard update for reachability metrics
5f81a2c 
Drop reachability poll interval to 60 secs
@pschork pschork force-pushed the pschork/reachability_check_config branch from fe323f2 to 5f81a2c Compare May 14, 2024 23:57
@jianoaix
Copy link
Contributor

It will be helpful to visualize this gauge over time (not just the reachability right now)

@shrimalmadhur
Copy link
Contributor

have we release a new version of DA yet? I am assuming this needs to be merged after we release that?

@pschork
Copy link
Collaborator Author

pschork commented May 15, 2024

It will be helpful to visualize this gauge over time (not just the reachability right now)

It is a time series. This show it being online, going down, coming back, then returning no data, then recovering.

image

@pschork
Copy link
Collaborator Author

pschork commented May 15, 2024

have we release a new version of DA yet? I am assuming this needs to be merged after we release that?

Cutting new release candidate today

shrimalmadhur
shrimalmadhur approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@shrimalmadhur shrimalmadhur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think once we have a new candidate release, we should update the holesky env and then merge this.

@pschork pschork merged commit 2c6015d into master May 15, 2024
@pschork pschork deleted the pschork/reachability_check_config branch May 15, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianoaix jianoaix jianoaix approved these changes

@shrimalmadhur shrimalmadhur shrimalmadhur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pschork @jianoaix @shrimalmadhur