Skip to content

Commit

Permalink
Fix docker build args and restore semver info on operator node
Browse files Browse the repository at this point in the history
The build args need to be defined in the builder context
  • Loading branch information
pschork committed Nov 1, 2024
1 parent f3cec0c commit 0f30fc3
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,11 +1,4 @@
# syntax=docker/dockerfile:1

# Declare build arguments
# TODO: this is only used for node image right now, should we also use it for nodeplugin?
ARG SEMVER=""
ARG GITCOMMIT=""
ARG GITDATE=""

FROM golang:1.21.1-alpine3.18 AS base-builder
RUN apk add --no-cache make musl-dev linux-headers gcc git jq bash

Expand Down Expand Up @@ -70,6 +63,9 @@ RUN --mount=type=cache,target=/go/pkg/mod \

# Node build stage
FROM common-builder AS node-builder
ARG SEMVER=""
ARG GITCOMMIT=""
ARG GITDATE=""
COPY node /app/node
COPY operators ./operators
WORKDIR /app/node
Expand Down

0 comments on commit 0f30fc3

Please sign in to comment.