Handle uint8 overflow (#363)

Layr-Labs · Mar 19, 2024 · 1438b7c · 1438b7c
1 parent 33d7268
commit 1438b7c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/core/auth/authenticator.go b/core/auth/authenticator.go
@@ -30,7 +30,7 @@ func (*authenticator) AuthenticateBlobRequest(header core.BlobAuthHeader) error
 	sig := header.AuthenticationData
 
 	// Ensure the signature is 65 bytes (Recovery ID is the last byte)
-	if sig == nil || len(sig) != 65 {
+	if len(sig) != 65 {
 		return fmt.Errorf("signature length is unexpected: %d", len(sig))
 	}
 

diff --git a/core/data.go b/core/data.go
@@ -76,7 +76,7 @@ type BlobRequestHeader struct {
 }
 
 func (sp *SecurityParam) Validate() error {
-	if sp.ConfirmationThreshold < sp.AdversaryThreshold+10 {
+	if sp.ConfirmationThreshold < sp.AdversaryThreshold || sp.ConfirmationThreshold-sp.AdversaryThreshold < 10 {
 		return errors.New("invalid request: quorum threshold must be >= 10 + adversary threshold")
 	}
 	if sp.ConfirmationThreshold > 100 {