unit tests

Layr-Labs · Nov 5, 2024 · 6ac6072 · 6ac6072
1 parent 99570a5
commit 6ac6072
Show file tree

Hide file tree

Showing 4 changed files with 356 additions and 2 deletions.
diff --git a/contracts/src/interfaces/IPaymentVault.sol b/contracts/src/interfaces/IPaymentVault.sol
@@ -19,6 +19,8 @@ interface IPaymentVault {
     event GlobalSymbolsPerSecondUpdated(uint256 previousValue, uint256 newValue);
     /// @notice Emitted when reservationBinInterval is updated
     event ReservationBinIntervalUpdated(uint256 previousValue, uint256 newValue);
+    /// @notice Emitted when globalRateBinInterval is updated
+    event GlobalRateBinIntervalUpdated(uint256 previousValue, uint256 newValue);
     /// @notice Emitted when priceParams are updated
     event PriceParamsUpdated(
         uint256 previousMinChargeableSize, 

diff --git a/contracts/src/payments/PaymentVault.sol b/contracts/src/payments/PaymentVault.sol
@@ -29,15 +29,17 @@ contract PaymentVault is PaymentVaultStorage, OwnableUpgradeable {
         uint256 _globalSymbolsPerSecond,
         uint256 _pricePerSymbol,
         uint256 _reservationBinInterval,
-        uint256 _priceUpdateCooldown
+        uint256 _priceUpdateCooldown,
+        uint256 _globalRateBinInterval
     ) public initializer {
-        transferOwnership(_initialOwner);
+        _transferOwnership(_initialOwner);
 
         minChargeableSize = _minChargeableSize;
         globalSymbolsPerSecond = _globalSymbolsPerSecond;
         pricePerSymbol = _pricePerSymbol;
         reservationBinInterval = _reservationBinInterval;
         priceUpdateCooldown = _priceUpdateCooldown;
+        globalRateBinInterval = _globalRateBinInterval;
 
         lastPriceUpdateTime = block.timestamp;
     }
@@ -52,6 +54,7 @@ contract PaymentVault is PaymentVaultStorage, OwnableUpgradeable {
         Reservation memory _reservation
     ) external onlyOwner { 
 		_checkQuorumSplit(_reservation.quorumNumbers, _reservation.quorumSplits);
+        require(_reservation.endTimestamp > _reservation.startTimestamp, "end timestamp must be greater than start timestamp");
         reservations[_account] = _reservation;
         emit ReservationUpdated(_account, _reservation);
     }
@@ -91,6 +94,11 @@ contract PaymentVault is PaymentVaultStorage, OwnableUpgradeable {
         reservationBinInterval = _reservationBinInterval;
     }
 
+    function setGlobalRateBinInterval(uint256 _globalRateBinInterval) external onlyOwner {
+        emit GlobalRateBinIntervalUpdated(globalRateBinInterval, _globalRateBinInterval);
+        globalRateBinInterval = _globalRateBinInterval;
+    }
+
     function withdraw(uint256 _amount) external onlyOwner {
         (bool success,) = payable(owner()).call{value: _amount}("");
         require(success);

diff --git a/contracts/src/payments/PaymentVaultStorage.sol b/contracts/src/payments/PaymentVaultStorage.sol
@@ -15,6 +15,8 @@ abstract contract PaymentVaultStorage is IPaymentVault {
     uint256 public globalSymbolsPerSecond;  
     /// @notice reservation bin duration 
     uint256 public reservationBinInterval;  
+    /// @notice global rate bin size
+    uint256 public globalRateBinInterval;
 
     /// @notice timestamp of the last price update
     uint256 public lastPriceUpdateTime;