remove duplicate validation

Layr-Labs · Dec 11, 2024 · 78f1b48 · 78f1b48
1 parent 63d53f5
commit 78f1b48
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 19 deletions.
diff --git a/disperser/apiserver/disperse_blob_v2.go b/disperser/apiserver/disperse_blob_v2.go
@@ -134,23 +134,19 @@ func (s *DispersalServerV2) validateDispersalRequest(ctx context.Context, req *p
 	// }
 
 	// handle payments and check rate limits
-	// if blobHeaderProto.GetPaymentHeader() != nil {
-	// 	binIndex := blobHeaderProto.GetPaymentHeader().GetBinIndex()
-	// 	cumulativePayment := new(big.Int).SetBytes(blobHeaderProto.GetPaymentHeader().GetCumulativePayment())
-	// 	accountID := blobHeaderProto.GetPaymentHeader().GetAccountId()
-
-	// 	paymentHeader := core.PaymentMetadata{
-	// 		AccountID:         accountID,
-	// 		BinIndex:          binIndex,
-	// 		CumulativePayment: cumulativePayment,
-	// 	}
-
-	// 	err := s.meterer.MeterRequest(ctx, paymentHeader, blobLength, blobHeader.QuorumNumbers)
-	// 	if err != nil {
-	// 		return api.NewErrorResourceExhausted(err.Error())
-	// 	}
-	// } else {
-	// 	return api.NewErrorInvalidArg("payment header is required")
+	// binIndex := blobHeaderProto.GetPaymentHeader().GetBinIndex()
+	// cumulativePayment := new(big.Int).SetBytes(blobHeaderProto.GetPaymentHeader().GetCumulativePayment())
+	// accountID := blobHeaderProto.GetPaymentHeader().GetAccountId()
+
+	// paymentHeader := core.PaymentMetadata{
+	// 	AccountID:         accountID,
+	// 	BinIndex:          binIndex,
+	// 	CumulativePayment: cumulativePayment,
+	// }
+
+	// err := s.meterer.MeterRequest(ctx, paymentHeader, blobLength, blobHeader.QuorumNumbers)
+	// if err != nil {
+	// 	return api.NewErrorResourceExhausted(err.Error())
 	// }
 
 	commitments, err := s.prover.GetCommitmentsForPaddedLength(data)

diff --git a/disperser/apiserver/server_v2_test.go b/disperser/apiserver/server_v2_test.go
@@ -4,12 +4,13 @@ import (
 	"context"
 	"crypto/rand"
 	"fmt"
-	"github.com/prometheus/client_golang/prometheus"
 	"math/big"
 	"net"
 	"testing"
 	"time"
 
+	"github.com/prometheus/client_golang/prometheus"
+
 	"github.com/Layr-Labs/eigenda/common/aws"
 	"github.com/Layr-Labs/eigenda/common/aws/dynamodb"
 	"github.com/Layr-Labs/eigenda/common/aws/s3"
@@ -203,7 +204,9 @@ func TestV2DisperseBlobRequestValidation(t *testing.T) {
 		Data:       data,
 		BlobHeader: invalidReqProto,
 	})
-	assert.ErrorContains(t, err, "authentication failed")
+	// TODO(hopeyen); re-enable this validation after adding signature verification
+	// assert.ErrorContains(t, err, "authentication failed")
+	assert.NoError(t, err)
 
 	// request with invalid payment metadata
 	invalidReqProto = &pbcommonv2.BlobHeader{