Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codeQL-scanning.yaml #1028

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

anupsv
Copy link
Contributor

@anupsv anupsv commented Dec 18, 2024

Why are these changes needed?

Codeql is throwing errors for certain files since the autobuild of codeql doesn't build contracts. So i'm adding a custom foundry install and forge build and then run the scan.

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant