Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

payment failure cases inabox #1035

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

hopeyen
Copy link
Contributor

@hopeyen hopeyen commented Dec 19, 2024

Why are these changes needed?

explicitly running out of funds for both payments (will rebase after merging #991, #1033, and #1034 , don't need to review yet)

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@hopeyen hopeyen force-pushed the hope/payments-v2-inabox branch from 1a5854f to ea6fe9b Compare December 20, 2024 03:20
Base automatically changed from hope/payments-v2-inabox to master December 20, 2024 03:37
@hopeyen hopeyen force-pushed the hope/payment-failure-inabox branch 3 times, most recently from 24c7a3a to 89c84de Compare December 20, 2024 03:58
@hopeyen hopeyen force-pushed the hope/payment-failure-inabox branch from 89c84de to d5ce40a Compare December 20, 2024 03:58
@hopeyen hopeyen requested a review from ian-shim December 20, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant