-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 contract diff #1040
base: mainnet-deploy
Are you sure you want to change the base?
V2 contract diff #1040
Conversation
require(success); | ||
} | ||
|
||
function withdrawERC20(address _token, uint256 _amount) external onlyOwner { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make this an IERC20
} | ||
|
||
function _deposit(address _account, uint256 _amount) internal { | ||
require(_amount <= type(uint80).max, "amount must be less than or equal to 80 bits"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should maintain an enumerable Address set of accounts
*/ | ||
abstract contract EigenDAThresholdRegistryStorage is IEigenDAThresholdRegistry { | ||
|
||
bytes public quorumAdversaryThresholdPercentages; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
natspec
import {IEigenDARelayRegistry} from "../interfaces/IEigenDARelayRegistry.sol"; | ||
import "../interfaces/IEigenDAStructs.sol"; | ||
|
||
contract EigenDABlobVerifier is IEigenDABlobVerifier { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't want this to be an internal library?
contract only diff from mainnet deploy