Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 contract diff #1040

Draft
wants to merge 1 commit into
base: mainnet-deploy
Choose a base branch
from
Draft

V2 contract diff #1040

wants to merge 1 commit into from

Conversation

0x0aa0
Copy link
Contributor

@0x0aa0 0x0aa0 commented Dec 19, 2024

contract only diff from mainnet deploy

require(success);
}

function withdrawERC20(address _token, uint256 _amount) external onlyOwner {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this an IERC20

}

function _deposit(address _account, uint256 _amount) internal {
require(_amount <= type(uint80).max, "amount must be less than or equal to 80 bits");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should maintain an enumerable Address set of accounts

*/
abstract contract EigenDAThresholdRegistryStorage is IEigenDAThresholdRegistry {

bytes public quorumAdversaryThresholdPercentages;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

natspec

import {IEigenDARelayRegistry} from "../interfaces/IEigenDARelayRegistry.sol";
import "../interfaces/IEigenDAStructs.sol";

contract EigenDABlobVerifier is IEigenDABlobVerifier {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't want this to be an internal library?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants