Create util to verify KZG commitment by generation and comparison #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: litt3 <[email protected]>
Signed-off-by: litt3 <[email protected]>
Signed-off-by: litt3 <[email protected]>
litt3
requested review from
anupsv,
epociask,
cody-littley,
bxue-l2 and
ian-shim
cody-littley
approved these changes
Dec 19, 2024
Signed-off-by: litt3 <[email protected]>
Signed-off-by: litt3 <[email protected]>
Signed-off-by: litt3 <[email protected]>
Signed-off-by: litt3 <[email protected]>
anupsv
approved these changes
Dec 20, 2024
anupsv
reviewed
Dec 20, 2024
| return fmt.Errorf("compute commitment: %w", err) | ||
| } | ||
|
|
||
| if claimedCommitment.X.Equal(&computedCommitment.X) && |
There was a problem hiding this comment.
i was going to say we'd need to check if claimedCommitment is on the curve but since its checked against what's computed locally, its fine.
samlaf
reviewed
Dec 20, 2024
|
|
||
| // GenerateBlobCommitment computes a kzg-bn254 commitment of blob data using SRS | ||
| func GenerateBlobCommitment( | ||
| kzgVerifier *verifier.Verifier, |
There was a problem hiding this comment.
Curious: why didn’t you make these methods on the verifier?
There was a problem hiding this comment.
Unconscious hesitancy to modify an existing utility, I suppose.
You're right, it's where the methods belong. I will fix this in an upcoming PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Checks