Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] Retriever server #1048

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[v2] Retriever server #1048

wants to merge 1 commit into from

Conversation

ian-shim
Copy link
Contributor

Why are these changes needed?

Simple server that wraps retrieval client

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim
Copy link
Contributor Author

I'll remove the indexer once #943 merges

@ian-shim ian-shim marked this pull request as ready for review December 20, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mooselumph mooselumph Awaiting requested review from mooselumph

@cody-littley cody-littley Awaiting requested review from cody-littley

@hopeyen hopeyen Awaiting requested review from hopeyen

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ian-shim