Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Retriever server #1048

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ian-shim
Copy link
Contributor

Why are these changes needed?

Simple server that wraps retrieval client

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim
Copy link
Contributor Author

I'll remove the indexer once #943 merges

@ian-shim ian-shim marked this pull request as ready for review December 20, 2024 18:54
@@ -17,6 +17,7 @@ require (
github.com/fxamacker/cbor/v2 v2.5.0
github.com/gin-contrib/logger v0.2.6
github.com/gin-gonic/gin v1.9.1
github.com/go-errors/errors v1.4.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the README, this utility attaches stack traces to the errors. Did you use this to debug something? If so, did you intend to leave it enabled in the code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants