Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some function names in comment #1050

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/spec/old/indexer.md
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ type HeaderStore interface{
// GetObject takes in a header and retrieves the accumulator object attached to the latest header prior to the supplied header having the requested object type.
GetObject(header Header, acc Accumulator) (AccumulatorObject, Header, error)

// GetObject retrieves the accumulator object attached to the latest header having the requested object type.
// GetLatestObject retrieves the accumulator object attached to the latest header having the requested object type.
GetLatestObject(acc Accumulator) (AccumulatorObject, Header, error)

}
Expand Down
4 changes: 2 additions & 2 deletions indexer/inmem/header_store.go
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ func (h *HeaderStore) GetObject(header *indexer.Header, acc indexer.Accumulator)
return obj, myHeader.Header, nil
}

// GetObject retrieves the accumulator object attached to the latest header having the requested object type.
// GetLatestObject retrieves the accumulator object attached to the latest header having the requested object type.
func (h *HeaderStore) GetLatestObject(acc indexer.Accumulator, finalized bool) (indexer.AccumulatorObject, *indexer.Header, error) {
header, err := h.GetLatestHeader(finalized)
if err != nil {
Expand All @@ -221,7 +221,7 @@ func (h *HeaderStore) GetLatestObject(acc indexer.Accumulator, finalized bool) (
return h.GetObject(header, acc)
}

// GetObject retrieves the accumulator object attached to the latest header having the requested object type.
// FastForward retrieves the accumulator object attached to the latest header having the requested object type.
func (h *HeaderStore) FastForward() error {
h.Chain = make([]*Header, 0)
return nil
Expand Down
2 changes: 1 addition & 1 deletion tools/traffic/workers/blob_reader_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import (
"golang.org/x/exp/rand"
)

// TestBlobReaderNoOptionalReads tests the BlobReader's basic functionality'
// TestBlobReader tests the BlobReader's basic functionality'
func TestBlobReader(t *testing.T) {
tu.InitializeRandom()

Expand Down