Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify commitment generation, and choose better name for util file #1063

Merged
merged 4 commits into from
Jan 3, 2025
Merged

Simplify commitment generation, and choose better name for util file #1063

merged 4 commits into from
Jan 3, 2025

Conversation

litt3
Copy link
Contributor

@litt3 litt3 commented Jan 2, 2025

Why are these changes needed?

  • This PR slightly reworks the commitment generation utility, to address concerns raised here
  • After further consideration, I decided that constructing a verifier just to compute a commitment is improper code reuse. Commitment generation only requires SRS data, which can be sourced from anywhere.

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@litt3 litt3 self-assigned this Jan 2, 2025
@litt3 litt3 marked this pull request as ready for review January 2, 2025 22:12
samlaf
samlaf approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks for this

api/clients/v2/verification/commitment_utils.go Outdated Show resolved Hide resolved
api/clients/v2/verification/commitment_utils_test.go Outdated Show resolved Hide resolved
@litt3 litt3 merged commit 9ff4a96 into Layr-Labs:master Jan 3, 2025
8 checks passed
@litt3 litt3 deleted the commitment-util-simplification branch January 3, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlaf samlaf samlaf approved these changes

@cody-littley cody-littley Awaiting requested review from cody-littley

@bxue-l2 bxue-l2 Awaiting requested review from bxue-l2

Assignees

@litt3 litt3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@litt3 @samlaf