Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[finalizer] Go through all confirmed blobs #217

Merged
merged 1 commit into from
Feb 9, 2024
Merged

[finalizer] Go through all confirmed blobs #217

merged 1 commit into from
Feb 9, 2024

Conversation

ian-shim
Copy link
Contributor

Why are these changes needed?

Previously, finalizer was only fetching 1MB worth of confirmed blob metadata to mark them as finalized.
It needs to go through all confirmed blob metadata to consider whether to mark them as finalized.

This PR also adds metrics for finalizer.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim marked this pull request as ready for review January 28, 2024 01:21
dmanc
dmanc reviewed Jan 28, 2024
View reviewed changes
disperser/batcher/metrics.go Outdated Show resolved Hide resolved
disperser/batcher/finalizer.go Show resolved Hide resolved
@ian-shim ian-shim force-pushed the finalizer-process-all-metadata branch 2 times, most recently from 4b70171 to 62b576b Compare January 28, 2024 08:58
@ian-shim ian-shim force-pushed the finalizer-process-all-metadata branch 2 times, most recently from c2c127d to 042b611 Compare January 29, 2024 19:02
siddimore
siddimore approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@siddimore siddimore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dmanc
dmanc approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@dmanc dmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

jianoaix
jianoaix reviewed Feb 1, 2024
View reviewed changes
disperser/batcher/metrics.go Outdated Show resolved Hide resolved
disperser/batcher/metrics.go Outdated Show resolved Hide resolved
disperser/batcher/metrics.go Outdated Show resolved Hide resolved
@ian-shim ian-shim force-pushed the finalizer-process-all-metadata branch from 042b611 to 65c10c9 Compare February 1, 2024 05:38
jianoaix
jianoaix approved these changes Feb 1, 2024
View reviewed changes
disperser/batcher/metrics.go Outdated Show resolved Hide resolved
@ian-shim ian-shim force-pushed the finalizer-process-all-metadata branch from 65c10c9 to 3c04348 Compare February 2, 2024 01:44
@ian-shim ian-shim force-pushed the finalizer-process-all-metadata branch from 3c04348 to ccddab2 Compare February 8, 2024 23:58
@ian-shim ian-shim merged commit ff2f2bd into Layr-Labs:master Feb 9, 2024
4 checks passed
@ian-shim ian-shim mentioned this pull request Feb 23, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianoaix jianoaix jianoaix approved these changes

@dmanc dmanc dmanc approved these changes

@siddimore siddimore siddimore approved these changes

@mooselumph mooselumph Awaiting requested review from mooselumph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ian-shim @siddimore @dmanc @jianoaix