Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataApi] Update endpts to spinal-case #261

Merged
merged 7 commits into from
Feb 27, 2024

Conversation

siddimore
Copy link
Contributor

@siddimore siddimore commented Feb 19, 2024

Why are these changes needed?

Define URI as spinal-case to make it compliant with RFC3986

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

Copy link
Contributor

@jianoaix jianoaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg, thanks for fixing it

disperser/dataapi/docs/docs.go Outdated Show resolved Hide resolved
@siddimore siddimore marked this pull request as ready for review February 22, 2024 18:17
Copy link
Contributor

@dmanc dmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would break the blob explorer. We would need to introduce new APIs, onboard the frontend, and then deprecate the old ones.

@dmanc
Copy link
Contributor

dmanc commented Feb 27, 2024

This would break the blob explorer. We would need to introduce new APIs, onboard the frontend, and then deprecate the old ones.

Actually maybe not, @QuinnLee do you use any of these endpoints?

@jianoaix
Copy link
Contributor

The blob explorer does. A safe way is to add new endpoint (with intended URI format), change frontend to use new endpoint, and then remove the old one.

@siddimore
Copy link
Contributor Author

The blob explorer does. A safe way is to add new endpoint (with intended URI format), change frontend to use new endpoint, and then remove the old one.

yup hence i added @QuinnLee to this PR, i will drop him a message as well once this gets merged

@siddimore
Copy link
Contributor Author

@QuinnLee can u kindly review this PR. Endpts are updated to kebab-case

@siddimore siddimore changed the title [DataApi] Update endpts to kebab-case [DataApi] Update endpts to spinal-case Feb 27, 2024
@QuinnLee
Copy link

approved, the blob explorer doesnt use any of these endpoints so it's safe to merge and ship

@siddimore siddimore merged commit df8e81d into Layr-Labs:master Feb 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants