-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataApi] Update endpts to spinal-case #261
[DataApi] Update endpts to spinal-case #261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg, thanks for fixing it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would break the blob explorer. We would need to introduce new APIs, onboard the frontend, and then deprecate the old ones.
Actually maybe not, @QuinnLee do you use any of these endpoints? |
The blob explorer does. A safe way is to add new endpoint (with intended URI format), change frontend to use new endpoint, and then remove the old one. |
yup hence i added @QuinnLee to this PR, i will drop him a message as well once this gets merged |
@QuinnLee can u kindly review this PR. Endpts are updated to kebab-case |
approved, the blob explorer doesnt use any of these endpoints so it's safe to merge and ship |
Why are these changes needed?
Define URI as spinal-case to make it compliant with RFC3986
Checks