Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop duplicating subgraph npm installation #263

Merged

Conversation

mooselumph
Copy link
Collaborator

Why are these changes needed?

Currently, we are copying the entire subgraph folder into the inabox test folder, resulting in the entire node_modules folder being duplicated many times. This also can cause problems due to permissions configurations of files in the node_modules folder. It's much better to just deploy the subgraph folder from its home location.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some relative path in https://github.com/Layr-Labs/eigenda/blob/master/subgraphs/eigenda-operator-state/subgraph.yaml#L3 which may need to fix

Also shall all the config files be moved to this directory and name it "config" or something (template looks like it's not fully specified and will be inherited by other configs)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a template in the sense that the addresses need to be correctly populated for each deployment. The other files not in this folder are actual complete configs as is, without needing modification for each deployment.

As part of the deployment script, the template is copied to the base directory and populated. Thus, none of the paths need to be updated.

Let me know if this all makes sense.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, sounds good

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, sounds good

@mooselumph mooselumph merged commit a46bd99 into Layr-Labs:master Feb 20, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants