Validate batch merkle root #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianoaix
approved these changes
Mar 4, 2024
core/validator.go
Outdated
| type ChunkValidator interface { | ||
| ValidateBatch([]*BlobMessage, *OperatorState, common.WorkerPool) error | ||
| ValidateBlob(*BlobMessage, *OperatorState) error | ||
| type DataValidator interface { |
There was a problem hiding this comment.
shall we create a name for data that's received by node (e.g. shard, BlobShard)? This naming may be more specific
There was a problem hiding this comment.
Are you suggesting changing BlobMessage into BlobShard?
There was a problem hiding this comment.
I'm suggesting "DataValidator" to something more specific such as "BlobShardValidator"
There was a problem hiding this comment.
DataMessageValidator? Shard stands out too much
There was a problem hiding this comment.
What about just ShardValidator?
ian-shim
approved these changes
Mar 5, 2024
bxue-l2
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Why is it needed, indeed.
Checks