Update signature aggregation test #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
force-pushed
the
aggregation-quorum
branch
3 times, most recently
from
a8b0960 to
052e86f
Compare
ian-shim
force-pushed
the
aggregation-quorum
branch
from
052e86f to
f433e3c
Compare
mooselumph
reviewed
Mar 11, 2024
mooselumph
reviewed
Mar 11, 2024
mooselumph
reviewed
Mar 11, 2024
| StartIndex: 4, | ||
| NumChunks: 2, | ||
| mock.MakeOperatorId(2): { | ||
| StartIndex: 3, |
There was a problem hiding this comment.
What were these changes for, just out of curiosity? Not transparent to me.
mooselumph
reviewed
Mar 11, 2024
mooselumph
reviewed
Mar 11, 2024
ian-shim
force-pushed
the
aggregation-quorum
branch
from
a63f5c4 to
4beb492
Compare
ian-shim
force-pushed
the
aggregation-quorum
branch
from
4beb492 to
59f5af6
Compare
bxue-l2
pushed a commit
to bxue-l2/eigenda
that referenced
this pull request
Apr 11, 2024
Co-authored-by: Robert Raynor <[email protected]>
bxue-l2
pushed a commit
to bxue-l2/eigenda
that referenced
this pull request
Apr 11, 2024
Co-authored-by: Robert Raynor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR refactors chain data mock to be more flexible and handle multiple quorums, and adds few more test cases for signature aggregation
Checks