Integrate EigenSDK wallet in batcher #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
commented
Mar 14, 2024
| @@ -482,7 +491,7 @@ func serializeProof(proof *merkletree.Proof) []byte { | |||
| return proofBytes | |||
| } | |||
|
|
|||
| func (b *Batcher) parseBatchIDFromReceipt(ctx context.Context, txReceipt *types.Receipt) (uint32, error) { | |||
There was a problem hiding this comment.
context isn't used here
| @@ -140,7 +140,7 @@ func mustNewSimulatedBackend() (client SimulatedBackend, deployerAddr common.Add | |||
| balance.SetString("10000000000000000000", 10) // 10 eth in wei | |||
|
|
|||
| deployerAddr = auth.From | |||
| genesisAlloc := map[common.Address]core.GenesisAccount{ | |||
There was a problem hiding this comment.
core.GenesisAccount has been deprecated
ian-shim
force-pushed
the
hotwallet-batcher
branch
2 times, most recently
from
8b9c30d to
635c50e
Compare
mooselumph
approved these changes
Mar 19, 2024
|
Looks good to me |
jianoaix
approved these changes
Mar 20, 2024
disperser/cmd/batcher/main.go
Outdated
| len(config.FireblocksConfig.VaultAccountName) > 0 { | ||
| secretKey, err := os.ReadFile(config.FireblocksConfig.SecretKeyPath) | ||
| if err != nil { | ||
| return fmt.Errorf("Cannot read fireblocks secret from %s: %w", config.FireblocksConfig.SecretKeyPath, err) |
There was a problem hiding this comment.
nit: lower case to "cannot.."
common/fireblocks_config.go
Outdated
| return []cli.Flag{ | ||
| cli.StringFlag{ | ||
| Name: PrefixFlag(flagPrefix, FireblocksAPIKeyFlagName), | ||
| Usage: "Fireblocks API Key. To configure Fireblocks MPC wallet, this field is required.", |
There was a problem hiding this comment.
comment that they can be empty string, in which case it'll fallback to private key wallet
There was a problem hiding this comment.
It's an optional parameter, so empty string doesn't need to be passed in to fall back to private key wallet.
I'll comment that it will fall back to private key wallet if not configured.
ian-shim
force-pushed
the
hotwallet-batcher
branch
from
f33fd8f to
4f920b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Integrates EigenSDK wallet interface for sending transactions and retrieving receipts from chain.
This will allow using both private key EOA and Fireblocks MPC wallet to send transactions with a single interface.
Checks