Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade lock for delete encoding request #357

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Upgrade lock for delete encoding request #357

merged 1 commit into from
Mar 19, 2024

Conversation

ian-shim
Copy link
Contributor

@ian-shim ian-shim commented Mar 18, 2024 •
edited
Loading

Why are these changes needed?

We should be using write lock when deleting item from the store.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim marked this pull request as ready for review March 18, 2024 05:36
@ian-shim ian-shim requested review from jianoaix and mooselumph March 18, 2024 05:36
@ian-shim ian-shim merged commit 2776648 into Layr-Labs:master Mar 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mooselumph mooselumph mooselumph approved these changes

@jianoaix jianoaix Awaiting requested review from jianoaix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ian-shim @mooselumph