Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check unexpected error and return when decoding chunks #359

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

ian-shim
Copy link
Contributor

@ian-shim ian-shim commented Mar 18, 2024

Why are these changes needed?

Check unexpected error and return when decoding chunks

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim force-pushed the return-err-instead-of-break branch from cbbd74d to fdd2e62 Compare March 18, 2024 15:51
@ian-shim ian-shim requested review from mooselumph and jianoaix March 18, 2024 16:04
@ian-shim ian-shim changed the title return err instead of breaking when buf read fails Check unexpected error and return when decoding chunks Mar 18, 2024
@ian-shim ian-shim marked this pull request as ready for review March 18, 2024 16:04
@ian-shim ian-shim merged commit 39aa5ac into Layr-Labs:master Mar 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants