Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update quorumConfirmationThresholdPercentages #364

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Update quorumConfirmationThresholdPercentages #364

merged 2 commits into from
Mar 19, 2024

Conversation

0x0aa0
Copy link
Contributor

@0x0aa0 0x0aa0 commented Mar 19, 2024

Why are these changes needed?

quorumConfirmationThresholdPercentages should be 55%

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@0x0aa0 0x0aa0 requested a review from mooselumph March 19, 2024 17:12
@0x0aa0 0x0aa0 merged commit 33d7268 into master Mar 19, 2024
6 checks passed
@0x0aa0 0x0aa0 deleted the quorum-threshold-update branch March 19, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mooselumph mooselumph mooselumph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x0aa0 @mooselumph