Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a param to return only live nonsigners #494

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Add a param to return only live nonsigners #494

merged 3 commits into from
Apr 22, 2024

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented Apr 18, 2024 •
edited
Loading

Why are these changes needed?

There are use cases to query just live nonsigners and all nonsigners in a time range.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@jianoaix jianoaix requested review from bxue-l2 and mooselumph April 18, 2024 06:05
@jianoaix jianoaix merged commit 4c3d53a into Layr-Labs:master Apr 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bxue-l2 bxue-l2 bxue-l2 approved these changes

@mooselumph mooselumph Awaiting requested review from mooselumph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jianoaix @bxue-l2