Optimize the quorum bitmap lookup when there is just one operator #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x0aa0
approved these changes
Apr 19, 2024
ian-shim
reviewed
Apr 19, 2024
core/eth/tx.go
Outdated
| Context: ctx, | ||
| }, t.Bindings.RegCoordinatorAddr, [][32]byte{byteId}, blockNumber) | ||
| if err != nil { | ||
| if err.Error() == "RegistryCoordinator.getQuorumBitmapIndexAtBlockNumber: no bitmap update found for operatorId at block number" { |
There was a problem hiding this comment.
does this equality match the err properly? have we checked this is the exact string that gets returned for this error?
There was a problem hiding this comment.
I think @0x0aa0 is helping check the details, but haven't tested yet
There was a problem hiding this comment.
Ok, I'm sure it's "execution reverted: RegistryCoordinator.getQuorumBitmapIndexAtBlockNumber: no bitmap update found for operatorId at block number"
ian-shim
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We are going to add operator registration metric at Node. When operator is querying their own metrics from the chain, we'd want to reduce the number of RPC calls needed.
Checks