Misc node log fixes #515
Merged
Misc node log fixes #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianoaix
changed the title
dmanc
approved these changes
May 14, 2024
| @@ -350,6 +350,7 @@ func (n *Node) ProcessBatch(ctx context.Context, header *core.BatchHeader, blobs | |||
| // revert all the keys for that batch. | |||
| result := <-storeChan | |||
| if result.keys != nil { | |||
| log.Debug("Batch validation failed, rolling back the key/value entries stored in database", "number of entires", len(*result.keys), "batchHeaderHash", batchHeaderHash) | |||
There was a problem hiding this comment.
Can we use batchHeaderHashHex instead
There was a problem hiding this comment.
"batchHeaderHash" is what is used elsewhere, I'm keeping it for consistency
node/node.go
Outdated
| n.Logger.Debug("Store batch took", "duration:", time.Duration(result.latency*float64(time.Millisecond))) | ||
| n.Logger.Debug("Store batch succeeded", "batchHeaderHash", batchHeaderHash, "duration:", time.Duration(result.latency*float64(time.Millisecond))) | ||
| } else { | ||
| n.Logger.Warn("Store batch skipped because the batch already exists in the store", "batchHeadherHash", batchHeaderHash) |
There was a problem hiding this comment.
typo: batchHeadherHash -> batchHeaderHash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Make sure each exit of batch processing has a log
Checks