Bucket level metric #542
Merged
Bucket level metric #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mooselumph
reviewed
May 7, 2024
mooselumph
reviewed
May 9, 2024
ian-shim
reviewed
May 22, 2024
| BlobSize: encodedSize, | ||
| Rate: globalRates.TotalUnauthThroughput, | ||
| RequesterID: key, | ||
| RequesterName: systemAccountKey, |
There was a problem hiding this comment.
shouldn't these be requesterName?
There was a problem hiding this comment.
Hmm I see how it's confusing but in this case we are calculating the system rate limit metric so we want to make sure the metric that is being updated corresponds to the name "system".
There was a problem hiding this comment.
I think to Ian's point, this might be a good reason to name these something like MetricsId and MetricsFlag, so that the intended usage is clear to the library user. Not super critical though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adds bucket level metrics to the rate limiter library. Currently I'm making an assumption that if the RequesterName is not empty then we've authenticated the request is some way.
Checks