Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused flag CACHE_ENCODED_BLOBS #562

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove unused flag CACHE_ENCODED_BLOBS #562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2376cc
Remove unused flag CACHE_ENCODED_BLOBS
dmanc May 14, 2024
162f1f5
Run ./gen.sh
dmanc May 14, 2024
be53642
Remove DISPERSER_SERVER_ALLOWLIST from config.go
dmanc May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 9 additions & 16 deletions encoding/kzg/cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,15 @@ import (
)

const (
G1PathFlagName = "kzg.g1-path"
G2PathFlagName = "kzg.g2-path"
CachePathFlagName = "kzg.cache-path"
SRSOrderFlagName = "kzg.srs-order"
NumWorkerFlagName = "kzg.num-workers"
VerboseFlagName = "kzg.verbose"
PreloadEncoderFlagName = "kzg.preload-encoder"
CacheEncodedBlobsFlagName = "cache-encoded-blobs"
SRSLoadingNumberFlagName = "kzg.srs-load"
G2PowerOf2PathFlagName = "kzg.g2-power-of-2-path"
G1PathFlagName = "kzg.g1-path"
G2PathFlagName = "kzg.g2-path"
CachePathFlagName = "kzg.cache-path"
SRSOrderFlagName = "kzg.srs-order"
NumWorkerFlagName = "kzg.num-workers"
VerboseFlagName = "kzg.verbose"
PreloadEncoderFlagName = "kzg.preload-encoder"
SRSLoadingNumberFlagName = "kzg.srs-load"
G2PowerOf2PathFlagName = "kzg.g2-power-of-2-path"
)

func CLIFlags(envPrefix string) []cli.Flag {
Expand Down Expand Up @@ -65,12 +64,6 @@ func CLIFlags(envPrefix string) []cli.Flag {
Required: false,
EnvVar: common.PrefixEnvVar(envPrefix, "VERBOSE"),
},
cli.BoolFlag{
Name: CacheEncodedBlobsFlagName,
Usage: "Enable to cache encoded results",
Required: false,
EnvVar: common.PrefixEnvVar(envPrefix, "CACHE_ENCODED_BLOBS"),
},
cli.BoolFlag{
Name: PreloadEncoderFlagName,
Usage: "Set to enable Encoder PreLoading",
Expand Down
18 changes: 8 additions & 10 deletions inabox/deploy/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,6 @@ func (env *Config) generateDisperserVars(ind int, key, address, logPath, dbPath,
DISPERSER_SERVER_TOTAL_UNAUTH_BLOB_RATE: "10,10",
DISPERSER_SERVER_PER_USER_UNAUTH_BLOB_RATE: "2,2",
DISPERSER_SERVER_ENABLE_RATELIMITER: "true",
DISPERSER_SERVER_ALLOWLIST: "3.221.120.68/0/1000/10485760,18.214.113.214/0/1000/10485760",

DISPERSER_SERVER_RETRIEVAL_BLOB_RATE: "4",
DISPERSER_SERVER_RETRIEVAL_BYTE_RATE: "10000000",
Expand Down Expand Up @@ -331,15 +330,14 @@ func (env *Config) generateRetrieverVars(ind int, key string, graphUrl, logPath,
RETRIEVER_CHAIN_RPC: "",
RETRIEVER_PRIVATE_KEY: key[2:],

RETRIEVER_G1_PATH: "",
RETRIEVER_G2_PATH: "",
RETRIEVER_G2_POWER_OF_2_PATH: "",
RETRIEVER_CACHE_PATH: "",
RETRIEVER_SRS_ORDER: "",
RETRIEVER_SRS_LOAD: "",
RETRIEVER_NUM_WORKERS: fmt.Sprint(runtime.GOMAXPROCS(0)),
RETRIEVER_VERBOSE: "true",
RETRIEVER_CACHE_ENCODED_BLOBS: "false",
RETRIEVER_G1_PATH: "",
RETRIEVER_G2_PATH: "",
RETRIEVER_G2_POWER_OF_2_PATH: "",
RETRIEVER_CACHE_PATH: "",
RETRIEVER_SRS_ORDER: "",
RETRIEVER_SRS_LOAD: "",
RETRIEVER_NUM_WORKERS: fmt.Sprint(runtime.GOMAXPROCS(0)),
RETRIEVER_VERBOSE: "true",

RETRIEVER_INDEXER_PULL_INTERVAL: "1s",
}
Expand Down
14 changes: 6 additions & 8 deletions inabox/deploy/env_vars.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,10 @@ type DisperserVars struct {

DISPERSER_SERVER_CLIENT_IP_HEADER string

DISPERSER_SERVER_ALLOWLIST string

DISPERSER_SERVER_ALLOWLIST_FILE string

DISPERSER_SERVER_ALLOWLIST_REFRESH_INTERVAL string

DISPERSER_SERVER_RETRIEVAL_BLOB_RATE string

DISPERSER_SERVER_RETRIEVAL_BYTE_RATE string
Expand Down Expand Up @@ -211,8 +211,6 @@ type EncoderVars struct {

DISPERSER_ENCODER_VERBOSE string

DISPERSER_ENCODER_CACHE_ENCODED_BLOBS string

DISPERSER_ENCODER_PRELOAD_ENCODER string

DISPERSER_ENCODER_G2_POWER_OF_2_PATH string
Expand Down Expand Up @@ -274,6 +272,8 @@ type OperatorVars struct {

NODE_EXPIRATION_POLL_INTERVAL string

NODE_REACHABILITY_POLL_INTERVAL string

NODE_ENABLE_TEST_MODE string

NODE_OVERRIDE_BLOCK_STALE_MEASURE string
Expand All @@ -296,6 +296,8 @@ type OperatorVars struct {

NODE_ECDSA_KEY_PASSWORD string

NODE_DATAAPI_URL string

NODE_G1_PATH string

NODE_G2_PATH string
Expand All @@ -310,8 +312,6 @@ type OperatorVars struct {

NODE_VERBOSE string

NODE_CACHE_ENCODED_BLOBS string

NODE_PRELOAD_ENCODER string

NODE_G2_POWER_OF_2_PATH string
Expand Down Expand Up @@ -373,8 +373,6 @@ type RetrieverVars struct {

RETRIEVER_VERBOSE string

RETRIEVER_CACHE_ENCODED_BLOBS string

RETRIEVER_PRELOAD_ENCODER string

RETRIEVER_G2_POWER_OF_2_PATH string
Expand Down
Loading